Sorting: assume standard sort is stable, try out the new toSorted method #52213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -60 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2b8cbad. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5505873098
|
tyxla
reviewed
Jul 3, 2023
There was a problem hiding this comment.
Neat idea to revisit the that sorting stability again 👍 There's definitely opportunities for cleanup.
We added it because it was not stable in React Native and we needed to upgrade, but my understanding is that it's stable now. See #45146 (comment) for more context.
There seem to be some tests failing - I havent' thoroughly looked at them, but could it be that Array.prototype.toSorted() isn't that well supported?
Also, I'm concerned about Array.prototype.toSorted() and its support in RN - we'll need to get a confirmation that it's safe to use.
cc @geriux for confirmation that Array.prototype.sort() is now stable in the Hermes version we're using and Array.prototype.toSorted() is fully supported.
tyxla
reviewed
Jul 3, 2023
There was a problem hiding this comment.
I'm also a bit concerned about the browser support of Array.prototype.toSorted(). For example, it's not supported in Chrome 109, but Chrome 109 is still used on over 2% of the devices, which according to the WordPress browser support policy means it's not supported:
Browsers with > 1% usage based on can I use browser usage table
I expected that it gets polyfilled by |
jsnajdr
force-pushed
the
update/sort-is-stable
branch
from
ec1ed49 to
2b8cbad
Compare
geriux
added
the
Mobile App - Automation
Hey there! It looks like it is not 😞 I confirmed this by checking the supported page and also by maually testing the app, the editor freezes until it ends up crashing. |
Ah, that's a bummer. Thanks for double-checking @geriux 🙌 |
jsnajdr
force-pushed
the
update/sort-is-stable
branch
from
2b8cbad to
a393ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array sort is specified as stable since 2019: https://stackoverflow.com/questions/3026281/what-is-the-stability-of-the-array-sort-method-in-different-browsers
This PR removes additional stabilizing code from
orderBy-- all our supported browsers should be compliant by now. I'm not sure myself whether this change is really safe. Let's experiment and discuss.Also I'm trying out the new
.toSorted()method that doesn't mutate the original array. To use it, I had to upgradecore-js,browserslistandcaniuse-liteto latest versions.