Page Content Focus: Add welcome guides #52014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Enhancement
noisysocks
requested review from
draganescu,
talldan,
tellthemachines,
adamziel and
kevin940726
as code owners
noisysocks
commented
Jun 28, 2023
editing-your-page.mp4
Outdated
There was a problem hiding this comment.
Will upload this file to s.w.org before merging.
noisysocks
commented
Jun 28, 2023
editing-your-template.mp4
Outdated
There was a problem hiding this comment.
Will upload this file to s.w.org before merging.
noisysocks
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +483 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
I closed both welcome guides after watching them the first time. |
@SaxonF What's expected here? |
noisysocks
force-pushed
the
add/page-content-focus-guides
branch
from
394aada to
65f9956
Compare
There is still value in a more general welcome guide outside of learning about switching to/from pages and templates which is more contextual. I think we should setup a follow-up issue that brings multiple steps into the site editor welcome guide including education around pages and templates in more abstract form like @jameskoster and @joen suggested in the original issue (similar to post editor). |
noisysocks
force-pushed
the
add/page-content-focus-guides
branch
from
683dbc7 to
3cc5240
Compare
noisysocks
force-pushed
the
add/page-content-focus-guides
branch
from
b2295eb to
78e289d
Compare
|
Just waiting to get the video files uploaded to s.w.org before merging. |
|
Flaky tests detected in b0de5fe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5440512449
|
tellthemachines
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Page Content Focus: Add welcome guides * Don't show when editor guide is active * Just use regular accent/theme color in all guides * slight copy change page guide * Update components changelog * Disable new guides in E2E tests * Use s.w.org videos --------- Co-authored-by: Saxon Fletcher <[email protected]>
tellthemachines
added a commit
that referenced
this pull request
Jul 3, 2023
* Footnotes: inscrease selector specificity for anchor (#52179) * Patterns: Include template parts for custom areas in Uncategorized category (#52159) * Fix custom patterns console error (#51947) * Fix error with react list key with new custom patterns list in inserter * Update placeholder key * Add comment to explain the different keys * Patterns: Fix missing custom patterns in patterns explorer (#51889) * Add custom patterns to pattern explorer * show custom patterns in the patterns explorer dialog * remove changes from 51877 * Fix up use of async lists * remove a bit of code duplication by adding a new hook * add 51877 fix back to make testing easier * Just assign the key value in one place * Refactor the custom patterns to use the usePatternsState hook * Fix use of async list * Translate strings and remove unneeded fields from pattern object * Try integrating unsynced patterns directly into pattern selectors (#51955) * Include reusable blocks with an undefined sync status in inserter items * Update docs * Remove change to hover dependencies --------- Co-authored-by: Daniel Richards <[email protected]> * i18n: Add context to the word "Filters" (#52198) * Update home template icon (#52075) * Centralise all permissions lookup in Link UI and enable (#52166) * BlockRemovalWarningModal: Fix incorrect '_n' usage (#52164) * Fix fetching Nav fallback ID flushing Navigation entity cache (#52069) * Only flush the `getEntityRecords` cache if the fallback isn’t already in state * Save the edited entity record to a const and then invert it to determine whether we should invalidate the recordds --------- Co-authored-by: scruffian <[email protected]> * Block Editor: Unify texts for Create pattern modal (#52151) * Fix history back after entering edit mode from Patterns (#52112) * Add template part icons to the library grid items (#51963) * Patterns: Fix sidebar tab label (#51953) * Patterns: Fix setting of sync status for fully synced patterns (#51952) * Library: Reinstate manage all template parts page (#51961) * Command Palette: fix incorrect path and snackbar message when template part is deleted (#52034) * Command Center: Fix incorrect navigation when deleting template part * removeTemplate: consider title type * Drop-indicator: remove white border. (#52122) * Make Navigation fallback selector private (#51413) * Move selector to become private * adds basic lock functionality * remove useless lock-unlock file * map private selectors to resolvers * Unlock the other usage * only create one fallback per session * Fix core-data duplicate private opt-in * Data: bind resolvers to selectors individually, support private selectors --------- Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: Jarda Snajdr <[email protected]> * Focus Mode: Use the symbol icon if a pattern is being edited (#52031) * Footnotes: register meta field for pages (#52024) * Fix unintentional toggling on of distraction free (#52090) * replace toggle with set preference - because I don't read code properly it seems * remove notification * Revert "Updating social link attributes (#51997)" (#52019) This reverts commit c711e2a. * Update home template name (#52048) * Removes unused call (#51988) * Remove ability for user to toggle sync status after pattern creation (#51998) * Fix disable DFM when opening styles command (#52165) * Update custom patterns label to 'My patterns' (#51949) * rename custom patterns to my patterns * Add my patterns label to inserter and show at the top --------- Co-authored-by: Daniel Richards <[email protected]> * Library: Add sync status to pattern details screen (#51954) * Patterns: Rename Library to Patterns (#52102) * [Library] Add lock icon for theme patterns (#51990) * Add lock icon for theme patterns * Change to class names * Add aria-description * Change wording * Patterns: Use "detached" copy consistently (#51993) * Editor initrial appender: Zero out margins in constrained layouts. (#52026) * Update pattern creation modal in library (#51946) * Fix missing snackbars in Library (#52021) * Make the entire preview clickable in order to enter "edit" mode in focus mode (#51973) * Page Content Focus: Add welcome guides (#52014) * Page Content Focus: Add welcome guides * Don't show when editor guide is active * Just use regular accent/theme color in all guides * slight copy change page guide * Update components changelog * Disable new guides in E2E tests * Use s.w.org videos --------- Co-authored-by: Saxon Fletcher <[email protected]> --------- Co-authored-by: Ella <[email protected]> Co-authored-by: Aaron Robertshaw <[email protected]> Co-authored-by: Glen Davies <[email protected]> Co-authored-by: Daniel Richards <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: James Koster <[email protected]> Co-authored-by: Dave Smith <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Carolina Nymark <[email protected]> Co-authored-by: Joen A <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Jarda Snajdr <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Ramon <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: Saxon Fletcher <[email protected]> Co-authored-by: Rich Tabor <[email protected]> Co-authored-by: Robert Anderson <[email protected]>
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
|
Removed the label as this was included in the package updates for Beta 3 yesterday. |
This change has an impact on accessibility. Please mark any PR that changes accessibility-related stuff (like the the Modal dialog initial focus in this case) with the accessibility label. It is certainly possible to not show the X button, although I'd prefer to always show it to provide a consistent user experience. However, when removing the X button and initial focus goes to the last element within the modal dialog, all the previous content gets skipped by screen readers. That's less than ideal, as screen reader users will have no clue there's some content before the 'Get started' button.
In this cases, it would be better to set initial focus on the modal dialog itself. Will create a new issue. |
|
Thanks @afercia! Good spotting. |
13 tasks
This was referenced Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #51822.
Adds welcome guides which appear to the user when they open a page in the site editor and when they edit that page's template.
How?
WelcomeGuidePageandWelcomeGuideTemplatecomponents in@wordpress/edit-sitedo the bulk of the lifting.WelcomeGuidein@wordpress/componentswhich is what all of our guides use.Testing Instructions
Dismissing the guides should prevent them from appearing again.
For testing purposes, you can run this in DevTools to re-enable the new guides:
Screenshots or screencast
The new guides:
Kapture.2023-06-28.at.16.59.39.mp4
The old guides: