Heading Block: Remove unused HeadingLevelIcon component
#52008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
carolinan
approved these changes
Jun 28, 2023
5 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #46003
What?
This PR removes the
HeadingLevelIconcomponent, which was used internally in the Heading block.Why?
In #46003, the heading block now uses a commonized
HeadingLevelDropdowncomponent to change the heading level. Accordingly, I have deleted theheading-level-icon.jsfile, which is no longer used.How?
This file has so far been used as an internal component of the heading block only and has not been imported from anywhere in the code base. It is also not externally exposed, so I think deleting it should not be a problem.
Testing Instructions