Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace babel-preset-latest with babel-preset-env #504

Merged
merged 1 commit into from
May 4, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 25, 2017

babel-preset-latest has been deprecated in favor of babel-preset-env. With consideration of recent browser support changes, combined with previously established browser support, browser targets have been configured as follows:

[
	"last 2 Chrome versions",
	"last 2 Firefox versions",
	"last 2 Safari versions",
	"last 2 iOS versions",
	"last 1 Android version",
	"last 1 ChromeAndroid version",
	"ie 11"
]

The advantage of defining browser support explicitly is that Babel can optimize to remove unnecessary transformations when supported by all supported versions.

Testing instructions:

Verify that build completes without errors.

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Apr 25, 2017
@mtias mtias added the [Type] Build Tooling Issues or PRs related to build tooling label May 3, 2017
Copy link
Contributor

@BE-Webdesign BE-Webdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Needs a rebase and merge.

@aduth aduth force-pushed the update/babel-preset-env branch from bc60c50 to 67b0014 Compare May 4, 2017 18:17
@aduth aduth force-pushed the update/babel-preset-env branch from 67b0014 to 7205fe1 Compare May 4, 2017 18:17
@aduth
Copy link
Member Author

aduth commented May 4, 2017

Thanks for the review @BE-Webdesign !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants