List View: Try allowing users to drag to one level up the hierarchy #49498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Feature] List View
|
Size Change: +138 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in aa4123b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4664732606
|
25 tasks
andrewserong
force-pushed
the
try/list-view-allow-drag-to-parent-level
branch
from
d466990 to
9d47b67
Compare
andrewserong
force-pushed
the
try/list-view-allow-drag-to-parent-level
branch
from
9d47b67 to
aa4123b
Compare
6 tasks
|
After hacking away at this a bit more, I have an idea for a more accurate way to do this, that will also allow dragging to all levels of the block hierarchy. I'll close out this PR for now, and will continue work over in #49742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
🚧 🚧 🚧 🚧 This is just a WIP PR for now — it is buggy and doesn't quite work yet! 🚧 🚧 🚧 🚧
An exploration into #33678 that looks at seeing if we could allow dragging just one level up the hierarchy.
Why?
It's important that folks can drag beneath a nested block. While it'd be good for folks to be able to drag to all levels of the hierarchy, this PR is exploring whether it'd be helpful to start with, to look at just allowing movement up a single level.
How?
This isn't complete yet, but the general idea is:
To-do
This doesn't work for the first level of hierarchy yet, as at the very root, there are no more parent client ids to grab. We need to add a check here — if we're at the root level, then we need slightly different logic.Implemented in 9d47b67, but it's pretty hacky and will need tidying up and to be commented.rootClientIdTesting Instructions
TBC
Testing Instructions for Keyboard
Screenshots or screencast
Coming soon...