Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote: Disable edit as HTML support #49426

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Quote: Disable edit as HTML support #49426

merged 1 commit into from
Mar 29, 2023

Conversation

Mamaduka
Copy link
Member

What?

This a follow-up to #49097 (review).
A similar PRs: #11785 and #39318.

PR disabled HTML editing for the Quote block.

Why?

Editing these wrapper blocks in HTML directly is fragile and prone to breaking the users' content. HTML editing should be left to leaf-blocks.

Testing Instructions

  1. Open a Post or Page.
  2. Insert a Quote block.
  3. Confirm "Edit as HTML" action isn't available in block Options.

Screenshots or screencast

CleanShot.2023-03-29.at.12.15.57.mp4

@Mamaduka Mamaduka requested a review from ntsekouras March 29, 2023 08:21
@Mamaduka Mamaduka self-assigned this Mar 29, 2023
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Quote Affects the Quote Block labels Mar 29, 2023
@Mamaduka Mamaduka merged commit 87c7611 into trunk Mar 29, 2023
@Mamaduka Mamaduka deleted the fix/quote-disable-html-editing branch March 29, 2023 09:04
@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 29, 2023
@shimotmk shimotmk mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@Mamaduka Mamaduka

Labels
[Block] Quote Affects the Quote Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 15.5
Development

Successfully merging this pull request may close these issues.
2 participants
@Mamaduka @ntsekouras