FormTokenField: Add prop to remove bottom margin #48609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
added
[Type] Enhancement
brookewp
force-pushed
the
update/formtokenfield-help
branch
from
6e70bc4 to
f8c394b
Compare
|
Size Change: -24 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
mirka
reviewed
Mar 1, 2023
There was a problem hiding this comment.
Thanks for this!
I haven't done a full review yet, but let's get the FormTokenField itself in good shape first before I start looking at the consumer code. I noticed a few more cases that need to be addressed:
- The bottom margin is gone even when
__nextHasNoMarginBottom = false. This needs to be maintained for back compat. (cf. current trunk) __experimentalShowHowTo = false&&__nextHasNoMarginBottom = truestill shows a bottom margin.
Thank you for the initial review and for catching those mistakes! 🙇♀️ I've resolved your initial findings! |
mirka
reviewed
Mar 2, 2023
There was a problem hiding this comment.
Note that we still need to maintain the margin when __experimentalShowHowTo = false && __nextHasNoMarginBottom = false.
By the way it might be good to reduce/redefine the scope of this PR to "FormTokenField: Add prop to remove bottom margin". We can focus on the FormTokenField itself, and merge quicker 👍 The consumer components can be addressed separately.
brookewp
changed the title
Ah, I thought we'd want to remove the margin-bottom there for the same reason. Thanks for pointing this out.
Makes sense! |
brookewp
force-pushed
the
update/formtokenfield-help
branch
from
9343c2c to
1103913
Compare
|
Flaky tests detected in bcf1a9f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4545977854
|
Are we going to reduce the scope of this PR? That means to move out the consumer changes (LatestPosts, QueryControls, HierarchicalTermSelector) into a separate PR so they can be reviewed better 🙂 It's actually how we did the rest of the components (as outlined in #38730 — Step 1: Implement the prop without adding a deprecation warning. Step 2: Migrate the usages in the codebase). I think it's especially worth it in this case because both concerns have some complexity involved. |
49 tasks
Ahh, thanks for clarifying! I think this might be a mistake in how I created this branch, which was a branch off of this one: #47515 So initially, the consumer changes were separated in the above PR. However, we need to deprecate the margin bottom from I'd love to hear your thoughts / if you have advice on how to proceed with the branches before I make further assumptions. 🙇♀️ |
mirka
requested review from
spacedmonkey,
noahtallen,
kevin940726,
fluiddot,
gziolo and
adamsilverstein
as code owners
brookewp
removed request for
noisysocks,
talldan,
gziolo,
swissspidy,
ntwb,
ajitbohra,
mmtr,
ryanwelcher,
nerrad,
adamsilverstein,
ellatrix,
geriux,
ajlende,
michalczaplinski,
dmsnell,
noahtallen,
kevin940726,
tellthemachines,
fluiddot,
ZebulanStanphill and
fabiankaegy
mirka
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39358
What?
Adds a
__nextHasNoMarginBottomprop to remove the bottom margin fromFormTokenField's help text.Why?
For easier reuse and consistency in spacing. This is also needed for #47515, where the removed margins cause spacing issues with the help text.
How?
This PR adds the flags and replaces the paragraph tag with
StyledHelp. The in-repo migration and official deprecation tasks will continue to be tracked at https://github.com/WordPress/gutenberg/issues/39358.]Additional Notes
I found that only QueryControls has
__experimentalShowHowToenabled in Gutenberg.Testing Instructions
npm run storybook:devFormFieldToken