SelectControl: Fix multiple prop styling
#47893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
mirka
commented
Feb 8, 2023
|
Size Change: +11.4 kB (+1%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dde2c96. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4144513799
|
ciampo
added
the
Backport to WP 6.7 Beta/RC
ciampo
reviewed
Feb 9, 2023
packages/components/src/select-control/styles/select-control-styles.ts
Outdated
Show resolved
Hide resolved
ntsekouras
pushed a commit
that referenced
this pull request
Feb 13, 2023
* SelectControl: Fix `multiple` prop styling * Update readme * Add changelog * Refactor padding code * Add comment * Allow overflow scrolling when `multiple` * Update snapshot
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: a4e7a4b |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27166
Continuation of #43213 (props @mediaformat!)
What?
Fixes the broken styling when the
multipleprop is enabled on SelectControl.Why?
Although the
multipleselect never appears in Gutenberg UI, it is an officially supported prop so it should be at least minimally usable.How?
multipleis enabled.FormTokenFieldorCheckboxControlinstead.Testing Instructions
npm run storybook:devand see the story for SelectControl.multipleprop. The entire select with all the options should be visible. It should look good in all size variants.multipleprop is disabled.Screenshots or screencast