Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin: Fix the 'WP_HTML_Tag_Processor' file path #47823

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Plugin: Fix the 'WP_HTML_Tag_Processor' file path #47823

merged 1 commit into from
Feb 7, 2023

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Feb 7, 2023 •
edited
Loading

What?

This is a follow-up to #47749.

PR fixes PHP fatal error caused by the typo with 'WP_HTML_Tag_Processor' file path when using Gutenberg with WP 6.1.

PHP Fatal error:  require(): Failed opening required '~/gutenberg/lib/compat/wordpress-6.2/html-api/class-wp-html-tag_processor.php' in ~/gutenberg/lib/load.php on line 98

Testing Instructions

Use WP 6.1 and check Gutenberg trunk vs this branch.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Feb 7, 2023
@Mamaduka Mamaduka requested review from gziolo and dmsnell February 7, 2023 10:40
@Mamaduka Mamaduka self-assigned this Feb 7, 2023
gziolo
gziolo approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it at the moment with WP 6.1, but the issue I missed when doing review is now obvious 🙈

@gziolo gziolo merged commit 5df361a into trunk Feb 7, 2023
@gziolo gziolo deleted the fix/html-processor-file-path branch February 7, 2023 12:22
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 7, 2023
@draganescu
Copy link
Contributor

Tested and it fixes the problem in 6.1

@dmsnell
Copy link
Member

dmsnell commented Feb 7, 2023

Thanks @Mamaduka - sorry that PR was merged before it was ready. Grateful for your quick follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@dmsnell dmsnell Awaiting requested review from dmsnell

Assignees

@Mamaduka Mamaduka

Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 15.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Mamaduka @draganescu @dmsnell @gziolo