Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the 'test_remove_invalid_element_pseudo_selectors' test case #47049

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

Mamaduka
Copy link
Member

What?

This a follow-up to #41786.

PR updates the 'test_remove_invalid_element_pseudo_selectors' test case's input value to match the test's intent.

Why?

The input and expected output were the same, so the test case wasn't testing invalid pseudo selector removal.

How?

I added an invalid pseudo selector to the input value.

Testing Instructions

PHP Unit tests are passing on CI.

npm run test:unit:php -- --filter WP_Theme_JSON_Gutenberg_Test

@Mamaduka Mamaduka requested a review from getdave January 11, 2023 08:14
@Mamaduka Mamaduka self-assigned this Jan 11, 2023
@Mamaduka Mamaduka added [Type] Task Issues or PRs that have been broken down into an individual action to take Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jan 11, 2023
@github-actions
Copy link

Flaky tests detected in 7684a5b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3890987182
📝 Reported issues:

Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. How on earth did I write a test like that 🤦

@Mamaduka Mamaduka merged commit 2d49496 into trunk Jan 11, 2023
@Mamaduka Mamaduka deleted the update/pseudo-selectors-unit-test branch January 11, 2023 11:22
@github-actions github-actions bot added this to the Gutenberg 15.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants