Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page List Item: Disable block toolbar #46950

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Page List Item: Disable block toolbar #46950

merged 1 commit into from
Jan 6, 2023

Conversation

scruffian
Copy link
Contributor

What?

This removes the "more" menu for page list item blocks:
Fixes #46751

Why?

These actions don't make sense on this block as you can't manipulate it directly.

How?

Adds the __experimentalToolbar support to the block.json

Testing Instructions

  1. Add a navigation block to a post
  2. Add a page list block to the navigation block
  3. Open the list view so that you can see the contents of the page list block
  4. Check that you can't see/access the "more" menu (under the three dots)
  5. Open the block inspector for the navigation block
  6. Expand the off canvas editor so that you can see the items inside the page list block
  7. Check that the page list items don't have a "more" menu (three dots)

Testing Instructions for Keyboard

As above

Screenshots or screencast

Screenshot 2023-01-06 at 16 13 53

Screenshot 2023-01-06 at 16 13 40

@scruffian scruffian added the [Block] Navigation Affects the Navigation Block label Jan 6, 2023
@scruffian scruffian self-assigned this Jan 6, 2023
@scruffian scruffian requested a review from ajitbohra as a code owner January 6, 2023 16:18
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Flaky tests detected in b38163b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3856721909
📝 Reported issues:

Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, I did not know that support already existed. I have tested the PR and it works well.

@scruffian
Copy link
Contributor Author

Neat, I did not know that support already existed.

Me neither!

@scruffian scruffian merged commit 5dd408c into trunk Jan 6, 2023
@scruffian scruffian deleted the fix/46751 branch January 6, 2023 18:37
@github-actions github-actions bot added this to the Gutenberg 15.0 milestone Jan 6, 2023
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs User Documentation Needs new user documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page List Item: Don't show a "more" menu.
3 participants