Navigation: Show the loading indictor when users add a new navigation menu #46855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
commented
Jan 3, 2023
| @@ -49,6 +51,24 @@ const MenuInspectorControls = ( { | |||
| [ clientId ] | |||
| ); | |||
|
|
|||
| const experimentMainContent = () => { | |||
There was a problem hiding this comment.
I extracted this as otherwise the different ternarys become hard to grok.
There was a problem hiding this comment.
Defining components within components should be avoided. Rather let's extract two components in the same file but outside the definition of the ` components:
<ExperimentControls /><DefaultControls />
This will fix the ternary problem that motivated the change whilst also making the code easier to read and better follow SRP.
There was a problem hiding this comment.
Thanks for the review. I added a commit for this.
|
Size Change: +55 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
getdave
requested changes
Jan 4, 2023
| @@ -49,6 +51,24 @@ const MenuInspectorControls = ( { | |||
| [ clientId ] | |||
| ); | |||
|
|
|||
| const experimentMainContent = () => { | |||
There was a problem hiding this comment.
Defining components within components should be avoided. Rather let's extract two components in the same file but outside the definition of the ` components:
<ExperimentControls /><DefaultControls />
This will fix the ternary problem that motivated the change whilst also making the code easier to read and better follow SRP.
scruffian
force-pushed
the
add/loading-to-inspector-controls
branch
from
9a25cf0 to
ad2a07c
Compare
ajlende
approved these changes
Jan 4, 2023
getdave
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As raised in #46140, we need to remove the off canvas editor when users are creating new menus, so that the UI reflects what is happening.
Why?
This makes it clear that something is happening when a new menu is being created.
How?
We pass the "isLoading" const down as a prop to MenuInspectorControls and use it to control the visibility of the OffCanvasEditor.
Testing Instructions
Testing Instructions for Keyboard
As above
Screenshots or screencast
Screen.Recording.2023-01-03.at.16.40.17.mov