Video Block: Fix browser warning error when settings are toggled #46835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Jan 1, 2023
| /> | ||
| <ToggleControl | ||
| label={ __( 'Playback controls' ) } | ||
| onChange={ toggleFactory.controls } | ||
| checked={ controls } | ||
| checked={ !! controls } |
There was a problem hiding this comment.
Strictly speaking, this is not necessary since control has a default value, but I handled this to unify with the other controls.
t-hamano
added
[Type] Code Quality
|
Size Change: +2 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
alexstine
approved these changes
Jan 1, 2023
|
I don't believe there are any problems with the code changes in the PR, but I am not able to reproduce the issue on trunk. Do I need any specific settings in devtools? |
Sorry for the inadequate explanation. You can check this error by setting |
I'm a muppet, I had |
carolinan
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the browser warning error that occurs when the toggle control value is changed in the block sidebar.
ee3a0798b500d66fe01f480b29bf0bd7.mp4
Why?
This is because the variables given as the initial value are
undefined.How?
I used
!!to convert them to boolean values.Testing Instructions