ColorPicker: Remove knobs in stories #46772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Dec 23, 2022
Comment on lines
-63
to
-69
| const LegacyExample = () => { | ||
| const [ legacyColor, setLegacyColor ] = useState( '#fff' ); | ||
| const legacyProps = { | ||
| color: legacyColor, | ||
| onChangeComplete: setLegacyColor, | ||
| disableAlpha: boolean( 'disableAlpha', true ), | ||
| }; |
There was a problem hiding this comment.
Removing the legacy example because this is/should be covered in the automated tests.
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Considering that the scope is to migrate away from knobs, this PR LGTM 🚀 Does it deserve a CHANGELOG entry?
Apart from that, we still need to:
- migrate the story to TypeScript and get the TS docgen to work
- see how we can split / exclude (or at least flag) legacy props from new props
Comment on lines
+20
to
+22
| // We can't use a `on*` regex because this component will switch to | ||
| // legacy mode when an onChangeComplete prop is passed. | ||
| onChange: { action: 'onChange' }, |
There was a problem hiding this comment.
Nice catch (and interesting nuance)!
| } | ||
|
|
||
| return ( | ||
| <Flex |
There was a problem hiding this comment.
I honestly don't remember why we had put two pickers side-by-side
There was a problem hiding this comment.
I have to assume it was to demonstrate that the values are synced over properly?
Nope, Storybook-only 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35665
What?
Remove the Knobs add-on from
ColorPickerstories.Why?
This is now a blocker for supporting npm 8 (#46443).
How?
Just a quick, minimal refactor.
Testing Instructions
npm run storybook:dev