Block editor: move content styles to avoid triggering iframe compat mode #46728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -48 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
I just noticed on
I wasn't sure if this is an issue with the order in which the CSS is loaded, or something more particular to how the styles are loaded in the iframe? |
|
I found today that the Query Loop block and its inner block's inspector controls are out of whack. The git bisect points to the commit for this PR. At first glance it didn't appear this PR should cause any dramas there so I re-ran the bisect again with the same results. Manually checking out the commit prior to this one works as expected. I've created an issue for this #47101. Would you have any ideas on what the issue is @ellatrix? |
|
@andrewserong It looks like there's a rule |
|
I saw the naked plus and actually liked it 😄 That said, it doesn't seem like an issue anymore, do you know if it was fixed separately?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently there's some new styles in the block-editor stylesheet that target blocks (content). These should be added to a separate content stylesheet so they can be properly added inside the iframe without using compat mode.
Why?
We shouldn't use compat mode in core, it's meant for plugin compat.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast