LinkControl unit tests: use user.type to type into search field #45802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
Mamaduka
added
the
[Feature] Link Editing
flootr
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
LGTM – I don't consider my comment a blocker.
There's one occurrence of searchInput.focus() left on line 754, shall we use the opportunity to wrap it in act?
|
|
||
| // Step down into the search results, highlighting the first result item. | ||
| triggerArrowDown( searchInput ); | ||
|
|
||
| createButton.focus(); | ||
| await user.keyboard( '[Enter]' ); | ||
| await user.click( createButton ); |
There was a problem hiding this comment.
The description for this test mentions creating entities via keyboard but here we're using a mouse event. As per your PR description it's clear to me why but it may be worth a comment so devs coming here in the future easily understand, too. What do you think?
There was a problem hiding this comment.
Oh yes, this should be fixed. But when I tried, it becomes a complex task. Let's do it in another PR: this one was supposed to be a search-and-replace easy fix.
There's one occurrence of searchInput.focus() left on line 754, shall we use the opportunity to wrap it in act?
Yes, but later, for the same reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpifies the
LinkControlunit tests by convertingto
because that's exactly what the
user.typehelper is for. It first doesuser.click( searchInput ), which focuses the element and then dispatches theclickevent, and then it doesuser.keyboard( searchTerm )on the focused element.This eliminates
searchInput.focus()calls which would have to be wrapped inact()during the React 18 migration (#45235). Using the higher-level abstraction saves us some work.We also don't need to focus before
user.clearbecauseuser.clearinternally focuses the element, too.At one place I had to convert
to
We're doing the click with a mouse instead of the keyboard, but it's an irrelevant detail for that particular test.