SelectControl: Add onChange, onBlur and onFocus to storybook actions #45432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
added
[Type] Enhancement
|
|
ciampo
approved these changes
Nov 1, 2022
| @@ -23,6 +23,7 @@ const meta: ComponentMeta< typeof SelectControl > = { | |||
| prefix: { control: { type: 'text' } }, | |||
| suffix: { control: { type: 'text' } }, | |||
| value: { control: { type: null } }, | |||
| onChange: { action: 'onChange' }, | |||
There was a problem hiding this comment.
An alternative that we could look into adopting across the package is to use a regex to mark as actions all on* props (see for example FocalPointPicker's Storybook parameters)
There was a problem hiding this comment.
Thanks. Didn't know you could do that. Would be great to get onBlur and onFocus as well. I'll update the PR later today.
There was a problem hiding this comment.
Updated the PR to match all on* using regex.
walbo
changed the title
ciampo
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Log
onChange,onBlurandonFocusprops to the Actions screen in Storybook.Why?
To see what
onChange,onBlurandonFocusdoes.How?
Update
SelectControlstorybook to log all props stating withonin the Actions screen.Testing Instructions
SelectControlstory and change the value.onChange,onBlurandonFocuswas logged in the Actions screen.Screenshots or screencast