Cherry pick PRs for inclusion in WP 6.1 RC-2 #45051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix overflowing patterns by using overflow:hidden * Revert "Fix overflowing patterns by using overflow:hidden" This reverts commit d47f721. * Make pattern list items position: relative so that position: absolute visually hidden text is positioned correctly
michalczaplinski
requested review from
ajitbohra,
noisysocks,
ellatrix and
tellthemachines
as code owners
|
Size Change: +130 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
PHP unit tests and e2e tests are currently failing because of a missing WP git tag (during wp-env setup I believe): It looks like the tip of |
|
This is the full stacktrace found in CI logs: Looks like the command might be coming from here: I think the gutenberg/packages/env/lib/wordpress.js Lines 241 to 272 in bf4eddb It doesn't seem like there are actually any tags like cc/ @noahtallen for |
|
Ah, looks like we actually have code to deal with pre-releases (alpha, beta, RCs): gutenberg/packages/env/lib/download-wp-phpunit.js Lines 121 to 131 in bf4eddb Seems like we "just" need to tweak the RegEx to understand this kind of RC version format. |
Let's make it case-insensitive then, shall we? diff --git a/packages/env/lib/download-wp-phpunit.js b/packages/env/lib/download-wp-phpunit.js
index 923750d58b..3900fd9495 100644
--- a/packages/env/lib/download-wp-phpunit.js
+++ b/packages/env/lib/download-wp-phpunit.js
@@ -122,7 +122,7 @@ async function downloadTestSuite(
// Alpha, Beta, and RC versions are bleeding edge and should pull from trunk.
let ref;
const fetchRaw = [];
- if ( ! wpVersion || wpVersion.match( /-(?:alpha|beta|rc)/ ) ) {
+ if ( ! wpVersion || wpVersion.match( /-(?:alpha|beta|rc)/i ) ) {
ref = 'trunk';
fetchRaw.push( 'fetch', 'origin', ref, '--depth', '1' );
} else { |
|
Heh, looks like that change is already in So I guess I'll revert my 8f05087 and will instead just cherry-pick that PR. |
…44887) WordPress version strings use '-RC1', not '-rc1'. This causes wp-env to look for a tag in wordpress-develop that does not exist, which in turn causes a fatal error.
|
Right on! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR to cherry-pick the Gutenberg changes for the WordPress 6.1 RC-2 release. The base of this PR is
wp/6.1.These are the commits/PRs that are being included here:
8a00f6a for PR: #45041 – Font Size Picker Hint: Fallbac...
9ad568e for PR: #45045 – Add: Missing output escaping o...
56c871a for PR: #44999 – Escape comment author URL
a68fa58 for PR: #44972 – Navigator: restore focus only ...
346ff74 for PR: #44858 – Spacing Sizes Control: Try imp...
6ef0ed8 for PR: #44878 – Fix: Inspector is usable on th...
a5efd9d for PR: #44809 – Fix list outdents on Enter in ...
1736a08 for PR: #44864 – List v2: fix selection when cr...
5f1a635 for PR: #44853 – Fix overflowing patterns
25d2b4c for PR: #45050 – Fix visibility of nested Group...
8048ef8 for PR: #44887 – wp-env: Use case insensitive regex...