Mobile - Update editor initial HTML test for iOS and update Appium #44732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
geriux
added
the
Mobile App - Automation
geriux
force-pushed
the
rnmobile/fix/ios-e2e-failures
branch
2 times, most recently
from
f4f770a to
c98347f
Compare
added 3 commits
October 7, 2022 12:49
…ition helper instead of a manual delay
geriux
force-pushed
the
rnmobile/fix/ios-e2e-failures
branch
from
aa51fdc to
fdd7dd7
Compare
geriux
changed the title
fluiddot
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
LGMT 🎊 ! Awesome work @geriux 🏅 !
After running the E2E tests three times all of them succeed ✅ , so looks like they're less flaky than before 🤞 .
| React Native E2E Tests (Android) | React Native E2E Tests (iOS) |
|---|---|
 |
 |
| @@ -16,22 +19,10 @@ describe( 'Gutenberg Editor Blocks test', () => { | |||
| lastBlockAccessibilityLabel | |||
| ); | |||
| } else { | |||
| lastBlockElement = await editorPage.getLastElementByXPath( | |||
| lastBlockAccessibilityLabel | |||
| lastBlockElement = await editorPage.getBlockAtPosition( | |||
There was a problem hiding this comment.
I noticed that getBlockAtPosition has an option to auto-scroll to the element, so we could use it also in the if ( isAndroid() ) case to simplify the test, wdyt?
There was a problem hiding this comment.
Thanks for the suggestion! I tried it but it is not working for this test, it begins to scroll down but then it stops just returning:
"//android.view.ViewGroup[contains(@content-desc, "Paragraph Block. Row 30")]" is still not visible after 25 retries!
I'm going to merge this so we can see how it performs in trunk, if there's any tweaks needed I could investigate it further to unify it for both platforms.
There was a problem hiding this comment.
Thanks for the suggestion! I tried it but it is not working for this test, it begins to scroll down but then it stops just returning:
"//android.view.ViewGroup[contains(@content-desc, "Paragraph Block. Row 30")]" is still not visible after 25 retries!
Ah, it's a shame that didn't work. Thanks for checking it 🙇 !
I'm going to merge this so we can see how it performs in trunk, if there's any tweaks needed I could investigate it further to unify it for both platforms.
Sure, my comment was just a suggestion, we can explore in the future enhancements to this test case.
geriux
removed
the
Mobile App - Automation
This was referenced Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
It updates the initial HTML test for iOS using the
getBlockAtPositionhelper instead of manually adding retry logic when trying to locate the last block.Why?
There were quite a few failures lately related to the iOS test.
How?
First, it updates the test to use
getBlockAtPositionwhich has the latest code improvements to find a block in E2E tests.It also updates:
1.22.3iPhone 1315.4For Android:
11.01.22.1(It doesn't support1.22.3yet)28. I tried different approaches but it would fail to boot the emulator, it looks like the machine it uses it's too slow and it times out.Dependabot updates that got merged before this PR:
Testing Instructions
Circle CI should pass, maybe try restarting the jobs to see if they succeed again.
Gutenberg Mobile PRs should also pass, including full test checks.
Screenshots or screencast
N/A