Remove unnecessary view.js file from navigation-submenu block
#44570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -423 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
It looks like it was removed from the block.json in #34675, so I think it's ok to delete this file. Would be good to get a confirmation/approval from @tellthemachines. |
talldan
added
[Type] Code Quality
tellthemachines
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Thanks for this PR! Yes, I somehow forgot to delete the old file in #34675 😳
talldan
deleted the
enhacement/remove-view-js-file-navigation-submenu-block
branch
bph
changed the title
view.js file from navigation-submenu blockview.js file from navigation-submenu block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If I am not mistaken, the current
view.jsfile in the navigation-submenu block is not being used. It isn't defined in the block.json (there is no viewScript field) and, if I add a submenu in the navigation block, it doesn't seem to load that view.js file in the browser.Apart from that, it seems the navigation block view.js file is doing mostly the same and seems a bit more up-to-date. This one is loaded in the browser.
Why?
If it is not being used, it is better to remove unnecessary code.
How?
I just removed the mentioned file.
Testing Instructions
navigationblock.