Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin: Remove 'gutenberg_rest_nonce' method #43805

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Plugin: Remove 'gutenberg_rest_nonce' method #43805

merged 1 commit into from
Sep 4, 2022

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Sep 2, 2022

What?

PR removes unused gutenberg_rest_nonce method.

Why?

I don't think this AJAX callback has been used since #19178. The core version of it (wp_ajax_rest_nonce) was introduced in WP 5.3

Testing Instructions

Doesn't affect anything. Just removing dead code.

@Mamaduka Mamaduka requested review from gziolo and removed request for spacedmonkey September 2, 2022 09:21
@Mamaduka Mamaduka self-assigned this Sep 2, 2022
@Mamaduka Mamaduka added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality labels Sep 2, 2022
@Mamaduka Mamaduka requested a review from aristath September 2, 2022 13:27
gziolo
gziolo approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. It was easy to miss before we put more structure into the plugin 👍🏻

@Mamaduka Mamaduka merged commit a1dcea4 into trunk Sep 4, 2022
@Mamaduka Mamaduka deleted the remove/gutenberg-rest-nonce branch September 4, 2022 09:08
@Mamaduka
Copy link
Member Author

Mamaduka commented Sep 4, 2022

Thanks for checking this on Sunday, @gziolo!

@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@aristath aristath Awaiting requested review from aristath

Assignees

@Mamaduka Mamaduka

Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Mamaduka @gziolo