From f2fb087a0c5ee0eb21b0ab34807be55c83b0b579 Mon Sep 17 00:00:00 2001 From: Mustaque Ahmed Date: Sun, 21 Aug 2022 21:56:01 +0530 Subject: [PATCH 1/3] tag-cloud: update docs to latest typography support --- docs/reference-guides/core-blocks.md | 2 +- packages/block-library/src/tag-cloud/block.json | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/docs/reference-guides/core-blocks.md b/docs/reference-guides/core-blocks.md index 24839c7311000e..9922636c1af1f6 100644 --- a/docs/reference-guides/core-blocks.md +++ b/docs/reference-guides/core-blocks.md @@ -797,7 +797,7 @@ A cloud of your most used tags. ([Source](https://github.com/WordPress/gutenberg - **Name:** core/tag-cloud - **Category:** widgets -- **Supports:** align, spacing (margin, padding), ~~html~~ +- **Supports:** align, spacing (margin, padding), typography (lineHeight), ~~html~~ - **Attributes:** largestFontSize, numberOfTags, showTagCounts, smallestFontSize, taxonomy ## Template Part diff --git a/packages/block-library/src/tag-cloud/block.json b/packages/block-library/src/tag-cloud/block.json index 69e14223f70fb7..d22310d74e0ffa 100644 --- a/packages/block-library/src/tag-cloud/block.json +++ b/packages/block-library/src/tag-cloud/block.json @@ -40,6 +40,18 @@ "spacing": { "margin": true, "padding": true + }, + "typography": { + "lineHeight": true, + "__experimentalFontFamily": true, + "__experimentalFontWeight": true, + "__experimentalFontStyle": true, + "__experimentalTextTransform": true, + "__experimentalTextDecoration": true, + "__experimentalLetterSpacing": true, + "__experimentalDefaultControls": { + "fontFamily": true + } } }, "editorStyle": "wp-block-tag-cloud-editor" From 1d1798ba1bfbb27c824847ff0c016b5a09338148 Mon Sep 17 00:00:00 2001 From: Mustaque Ahmed Date: Sun, 2 Oct 2022 10:46:36 +0530 Subject: [PATCH 2/3] remove default control for tag-cloud block --- packages/block-library/src/tag-cloud/block.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/block-library/src/tag-cloud/block.json b/packages/block-library/src/tag-cloud/block.json index d22310d74e0ffa..09d23d6c9b1697 100644 --- a/packages/block-library/src/tag-cloud/block.json +++ b/packages/block-library/src/tag-cloud/block.json @@ -48,10 +48,7 @@ "__experimentalFontStyle": true, "__experimentalTextTransform": true, "__experimentalTextDecoration": true, - "__experimentalLetterSpacing": true, - "__experimentalDefaultControls": { - "fontFamily": true - } + "__experimentalLetterSpacing": true } }, "editorStyle": "wp-block-tag-cloud-editor" From 7bdd9fe02bc75e62afae886a3650e94ddda73102 Mon Sep 17 00:00:00 2001 From: Mustaque Ahmed Date: Tue, 4 Oct 2022 17:26:54 +0530 Subject: [PATCH 3/3] remove `__experimentalTextDecoration` as typography support this is done because of the serialization issues with the typography support as mentioned in the comment. https://github.com/WordPress/gutenberg/pull/43452#pullrequestreview-1100081459 --- packages/block-library/src/tag-cloud/block.json | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/block-library/src/tag-cloud/block.json b/packages/block-library/src/tag-cloud/block.json index 09d23d6c9b1697..c722227398603f 100644 --- a/packages/block-library/src/tag-cloud/block.json +++ b/packages/block-library/src/tag-cloud/block.json @@ -47,7 +47,6 @@ "__experimentalFontWeight": true, "__experimentalFontStyle": true, "__experimentalTextTransform": true, - "__experimentalTextDecoration": true, "__experimentalLetterSpacing": true } },