Lodash: Remove completely from @wordpress/create-block package
#43362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
tyxla
requested review from
ntsekouras,
swissspidy,
jorgefilipecosta,
sgomes,
aristath,
chad1008 and
fabiankaegy
sgomes
approved these changes
Aug 18, 2022
| @@ -66,7 +61,7 @@ const dashicon = { | |||
| message: | |||
| 'The dashicon to make it easier to identify your block (optional):', | |||
| validate( input ) { | |||
| if ( ! isEmpty( input ) && ! /^[a-z][a-z0-9\-]*$/.test( input ) ) { | |||
There was a problem hiding this comment.
Why was _.isEmpty being used on a string? So odd.
There was a problem hiding this comment.
This was added 3 years ago and back then using Lodash was just fine for anything 🤷 .
There was a problem hiding this comment.
I don't think it was about the length then you could leave it up to the regular expression that requires a starting letter. I don't remember what input can resolve to, but I guess it might be better to check if the input is a string.
There was a problem hiding this comment.
FWIW, I've tried setting a dashicon to both 5 and an empty string and it always worked well, seems like it's always a string:
There was a problem hiding this comment.
Great, thank you for confirming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all of the Lodash from the
@wordpress/create-blockpackage, including thelodashdependency altogether. There are just a few usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495While this PR doesn't affect bundle size at all (because this package's code is not bundled), it still is a step forward in the direction of completely getting rid of Lodash in Gutenberg.
How?
We're using native JS functionality -
pickByandomitByare replaced withObject.fromEntries( Object.entries().filter() ),forEach()for an object is also replaced byObject.entries().forEach(), andisEmptyis replaced with a simpler alternative due to the fact that we don't need the granularity.Testing Instructions
npx @wordpress/create-blockand go through the prompts to verify everything still works well.npx @wordpress/create-block example-block --title My Example Block(and maybe some additional arguments) and verify everything still works well.nvm install v10.24.1)npx @wordpress/create-blockand verify you're still getting the minimum system requirements error.