Cover block: adding background-size and background-repeat properties to the block CSS #42470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbenedetto
added
[Block] Cover
|
Size Change: +11 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Jul 17, 2022
|
Since this broke live sites, would it be possible for the fix to make next Gutenberg release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding background-size and background-repeat properties to the block cover CSS when it is set to fixed background.
Why?
To make the fixed background functionality work more consistently with all the image sizes.
How?
Previously we were not applying a background-size property so the background image was using
auto, the default value. The default value scales the background image in the corresponding direction such that its intrinsic proportions are maintained..Testing Instructions
Screenshots or screencast
Before:
After: