Post title: fix single line paste #42321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
mcsf
approved these changes
Jul 14, 2022
dmsnell
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Worth getting the fix in.
Do you think the content.slice(1) could be the issue? I noticed that when selecting a single line we receive and empty <span> from Google Docs with some ref id in it. That was moved to the beginning of the pieces in the raw handler even though it came after the HTML.
Maybe we can continue to explore this after merge and see if there isn't something going on with shortcodeConverter or another part of the process.
No, that only happens when the pasted content is an array of blocks, in which case we're taking out the first block if it's a heading or paragraph and paste that into the title. In this case the HTML is already filtered through the The problem was that for single lines of content, we were accidentally letting the browser insert the unfiltered HTML instead of preventing default and inserting our cleaned up HTML. |
ellatrix
force-pushed
the
fix/post-title-past-single-line
branch
from
0a710b0 to
f8e66f6
Compare
|
Added a test, I'll merge when it passes. |
ah this makes more sense; I had this suspicion I hadn't yet confirmed that we were losing track of the content input into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #38637. The problem is that we forgot to handle the case when the pasteHandler outputs a string. Since we also didn't prevent default behaviour, the browser is handling it, which makes it seems like everything is working fine. But the browser will paste unfiltered HTML.
I guess we should add an e2e test?
Why?
How?
Testing Instructions
Screenshots or screencast