useSelect: add async mode test suite and fix two bugs #40321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
|
Size Change: +19 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a suite of unit tests for
useSelectthat test behavior when async mode is enabled. They verify that updates are correctly executed as scheduled, and that they are cancelled when needed -- unmount, mode change, etc.One example of what kind of bugs they can catch is the changes in #19286 that fixed the render queue two years ago. If you try to revert these changes on your working copy, the unit tests will start failing.
The PR also fixes two bugs that I discovered while writing these tests:
onChange()invocation in an effect that subscribes to the store. Its purpose is to catch missed updates that happened between the initial render and running the effect. This invocation should always be synchronous, even in async mode. But it was async in async mode.registrychanges, it should trigger a new call tomapSelect. But that was not happening. Right afterregistrychanged, there was one inconsistent render where there was newregistryand the old memoized value ofmapSelect, from the oldregistry. It was immediately fixed in effect when invokingonChange, but still, the inconsistent render was there.