Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: withAPIData: Don't restrict endpoints to /wp/v2 #3778

Merged
merged 1 commit into from
Dec 3, 2017
Merged

Components: withAPIData: Don't restrict endpoints to /wp/v2 #3778

merged 1 commit into from
Dec 3, 2017

Conversation

donnapep
Copy link
Contributor

@donnapep donnapep commented Dec 3, 2017

Description

Fixes #3209.

How Has This Been Tested?

  1. Set up a site with the appropriate branches of Sensei and Sensei Courses according to the instructions in the parent issue. Set up a post/page in Gutenberg according to the instructions and use the Network inspector.
  2. Make sure that a successful request to /sensei/v1/courses is found alongside the request to /wp/v2/course-category.
  3. Make sure core blocks aren't affected by this (e.g. Latest Posts), nor other consumers of withAPIData within the framework (e.g. sidebar controls).

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@aduth aduth merged commit 499b320 into WordPress:master Dec 3, 2017
@donnapep donnapep deleted the update/withAPIData-all-root-namespace branch December 5, 2017 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants