Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements: Add styles to the footer before the block is rendered #37728

Merged
merged 12 commits into from
Apr 13, 2022
Merged

Elements: Add styles to the footer before the block is rendered #37728

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d43a3ce
Add styles to the footer before the block is rendered
scruffian Jan 5, 2022
2d50ea2
Update PHPDoc
scruffian Jan 13, 2022
e34c716
Fix php unit test - length of id was changed by this PR
Feb 10, 2022
9b22cad
Fix linting errors and elements unit tests
Feb 10, 2022
46e5e40
add removed code
scruffian Apr 4, 2022
4c65449
consolidate code from rebase
scruffian Apr 6, 2022
4b8f820
Try adding a unit test
scruffian Apr 6, 2022
653aede
fix test
scruffian Apr 6, 2022
92cc1ab
Do not short-circuit block rendering
oandregal Apr 13, 2022
e524d1d
Rename for clarity
oandregal Apr 13, 2022
f67438c
Do not output styles if skipSerialization is true
oandregal Apr 13, 2022
6aca09e
Remove unnecessary test
oandregal Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/block-supports/elements.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ function gutenberg_render_elements_support_footer( $pre_render, $block ) {
$style = ".$class_name a{" . $link_color_declaration . ';}';

gutenberg_enqueue_block_support_styles( $style );
return $style;

return null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that for the sake of the test...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the test I suggested we should have. As you said, in this case, the value would lie in a e2e test. It'd be great to have it :)

}

// Remove WordPress core filter to avoid rendering duplicate elements stylesheet.
Expand Down