State: Deduplicate notices by distinct ID #3764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to update the behavior of notices reducer to respect ID as a unique identifier, removing duplicate entries. The revised behavior appends the latest notice as the last value in the set, removing any prior entries which share the same ID.
Testing instructions:
Ensure that unit tests pass:
Currently there do not appear to be any situations in which a duplicate notice would be shown, only because the behavior of saving explicitly calls to remove the existing notice.
gutenberg/editor/effects.js
Line 76 in c4444e4
However, this has shown to be an issue in #3378 where saving a reusable block displays a notice with a common ID.