Revert Query Pagination Next/Previous placeholder(36681) #37520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Package] Block library
ntsekouras
requested review from
ajitbohra,
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: -165 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
I don't think there is something to look at for Maybe you'll have to take a look at the follow up later with the small fix about showing a |
mcsf
approved these changes
Dec 21, 2021
ntsekouras
deleted the
revert/query-pagination-next-previous-placeholder
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussions, some recent changes to Query Pagination Next/Previous blocks to show placeholders were decided to be reverted.
That PR couldn't be automatically reverted by GitHub, so this PR will do it.
In addition during the discussion about the changes a bug was found that will be addressed in a follow up.
Testing instructions