Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show group on top in multi select toolbar #37488

Conversation

jiteshdhamaniya
Copy link
Contributor

Description

This PR Solves this Issue #34461.
in multi-select toolbar it shows Group before copy, and in Single select it shows Group in current position. However Ungroup is always shows before copy.

Screenshot 2021-12-17 at 6 51 33 PM

Screenshot 2021-12-17 at 6 45 20 PM

Screenshot 2021-12-17 at 7 26 30 PM

How has this been tested?

Steps -

  • Create Multiple Blocks
  • Select Multiple blocks, click on Kebab Menu (Three dots) icon
  • You will see Group Menu after Copy (First Outcome)
  • Now click on Group to group them.
  • Click on Kebab Menu Again, you will see Ungroup Menu in Same position. (Second Outcome)
  • Now Select a single Block, Click on Kebab Menu, and you will see Group Menu Next to Add to Reusable Blocks (Third Outcome), (its currently all the time on this position which this PR changes, for multi-select toolbar)

Screenshots

Screenshot 2021-12-17 at 7 31 00 PM

Types of changes

Feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 17, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jiteshdhamaniya! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jiteshdhamaniya !

We should show the group in multi-select toolbar as you already mentioned in the issue afterwards.

@mtias in order to add it to multi-select toolbar, we need an icon, is there any existing icon we can use?

I guess just the Group block icon would do just fine but let's get some thoughts from @jasmussen or @jameskoster maybe?

@mtias
Copy link
Member

mtias commented Dec 20, 2021

We should not move the position of items in the ellipsis menu, which can be disorienting and feel arbitrary. We should add a shortcut for "group" in the toolbar, maybe next to the ellipsis menu for multi-selection. And yes, the group icon should be used.

@jiteshdhamaniya jiteshdhamaniya deleted the show-group-on-top-in-multi-select-toolbar branch December 23, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants