Update: Block top level useSetting paths. #37428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Code Quality
|
Size Change: +65 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
oandregal
reviewed
Dec 16, 2021
| @@ -15,6 +15,8 @@ import { __EXPERIMENTAL_PATHS_WITH_MERGE as PATHS_WITH_MERGE } from '@wordpress/ | |||
| import { useBlockEditContext } from '../block-edit'; | |||
| import { store as blockEditorStore } from '../../store'; | |||
|
|
|||
| const blockedPaths = [ 'color', 'typography', 'spacing' ]; | |||
There was a problem hiding this comment.
My first instinct would be to also block border and layout for consistency. However, layout is the only one that is actually accessed directly.
There was a problem hiding this comment.
I left useSetting( 'layout' ) as it seems the use cases make sense. I removed the border.
oandregal
reviewed
Dec 16, 2021
| @@ -104,6 +106,9 @@ export default function useSetting( path ) { | |||
|
|
|||
| const setting = useSelect( | |||
| ( select ) => { | |||
| if ( blockedPaths.includes( path ) ) { | |||
| return undefined; | |||
There was a problem hiding this comment.
Can we throw a message (and add a comment) so the purpose is clear?
oandregal
approved these changes
Dec 16, 2021
jorgefilipecosta
force-pushed
the
update/block-top-level-useSetting-paths
branch
from
3b7e066 to
11f5019
Compare
jorgefilipecosta
force-pushed
the
update/block-top-level-useSetting-paths
branch
from
11f5019 to
9fb2886
Compare
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #37094
This PR blocks top-level useSetting calls e.g: useSetting( 'color' ), in order to avoid bugs given that these calls don't take back-compatibility and other logic into consideration.