Add missing border to colors #36678
Closed
Add missing border to colors #36678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
changed the title
|
Size Change: +27 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
|
|
Code looks good. I think this can work well, but I have no strong opinion personally — except for the white color swatch, I do also apprecite the borderless version. I've CC'ed Pablo for a quick take. |
kellychoffman
approved these changes
Nov 27, 2021
|
Hey, @richtabor It looks like you need to rebase this branch, and we can merge after it. |
|
@Mamaduka I'll close this — seems it was fixed in another PR since then.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added missing borders for colors, as noted in #36543
Screenshots
Types of changes
Bug fix, CSS
Checklist:
*.native.jsfiles for terms that need renaming or removal).