Media upload: refactor to functional component #36131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Size Change: -71 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
ramonjd
force-pushed
the
update/refactor-media-upload-to-functional-component
branch
from
3400b22 to
117ef2f
Compare
ramonjd
force-pushed
the
update/refactor-media-upload-to-functional-component
branch
from
117ef2f to
c907707
Compare
Refactoring method order.
ramonjd
changed the title
|
The failing e2e test – the media library not opening for the inline image - is real. I think it's because the former reference to |
|
Going to close this as, aside from the janitorial intentions, it has no real user value. |
ramonjd
deleted the
update/refactor-media-upload-to-functional-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #35973, I refactored the
MediaUploadcomponent for no reason other than [insert reason here].How has this been tested?
In the Gutenberg editor.
Uploading various media to the Image, Gallery, Cover and Audio Blocks, and the Post Feature Image, via (where appropriate):
Ensure the media library collection reflects the current selection. For example, add an image to the Gallery and make sure your gallery images are selected.
Edit an image via the media library.
Things should work as usual.
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).