Storybook: Enable Controls and disable Knobs by default #35682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
force-pushed
the
storybook/knobs-to-controls
branch
from
0317990 to
c9dd495
Compare
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
mirka
force-pushed
the
storybook/knobs-to-controls
branch
from
a2eca29 to
067511b
Compare
ciampo
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35665
Description
Knobs are now deprecated. New stories should be written using Controls, as this will make things much simpler both in terms of initial setup and adding additional stories using
argscomposition.Proposed changes
@storybook/addon-controls.@storybook/addon-knobsglobally by default.The intent is to discourage further use of Knobs, and to make it easier to migrate to Controls whenever existing stories are reworked.
How has this been tested?
✅ A search for
from '@storybook/addon-knobs'matches 50 story files. All 50 of these files have been touched to enable Knobs specifically on that file.✅
npm run storybook:devand check that the Controls panel is enabled, and the Knobs panel is enabled only where currently used.Types of changes
Storybook only, no breaking changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).