Query Pagination: Don't render an empty container #35092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
ntsekouras
and removed request for
ajitbohra
Mamaduka
added
[Block] Query Pagination
Mamaduka
changed the title
|
Size Change: +41 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
fix/empty-query-pagination-render
branch
from
f60a349 to
ba98be8
Compare
jffng
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Thank you for working on this! It works as advertised — no container is rendered if pagination is empty.
I think this change requires block themes to update their templates if they reference the old query pagination markup. For example, tt1-blocks: https://github.com/WordPress/theme-experiments/blob/master/tt1-blocks/block-templates/index.html#L51 — this wrapping div has to be removed for the container not to be rendered.
Should that be documented somewhere?
This was referenced Sep 28, 2021
|
Hi, @jffng With deprecation in place, old templates shouldn't break, but I think the update would be good.
Not sure what would be the best place for this. I guess once FSE is stable, we will include similar changes in |
carolinan
approved these changes
Sep 29, 2021
|
Thanks for testing/reviews, @jffng and @carolinan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30522.
Alternative to #33635.
Updates Query Pagination block to use
render_callbackfor rendering containerdivelement. Render callback won't render anything if block content is empty.How has this been tested?
perPagenumber so it shouldn't display pagination.perPageonce again, so now it renders paginations.Example Query
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).