components: Remove duplicated space utilities #32852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
sarayourfriend
added
[Feature] Component System
|
Size Change: -11 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
@sarayourfriend would you mind rebasing, since the merging of #32566 caused some conflicts? The new Thank you! |
sarayourfriend
force-pushed
the
fix/remove-duplicated-space-utilities
branch
from
77fa4eb to
4eede0b
Compare
ciampo
approved these changes
Jun 22, 2021
sarayourfriend
force-pushed
the
fix/remove-duplicated-space-utilities
branch
from
4eede0b to
7bca4d4
Compare
sarayourfriend
force-pushed
the
fix/remove-duplicated-space-utilities
branch
from
7bca4d4 to
6b3ad2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the old
spaceutility and replaces it with the one fromui. In a follow up PR I'll move theui/utils/spaceinto the upperutilsfolder.Note: The old space utility used a base of 8 and the new one uses a base of 4, so I just had to double all the values being passed into the old utility.
How has this been tested?
Test in storybook. Go to each of the affected components (
BaseControl,RangeControl,Navigation, andCard) and compare against production (https://wordpress.github.ui/gutenberg) and ensure that the padding and spacings are all the same.Types of changes
Janitorial, clean up
Checklist:
*.native.jsfiles for terms that need renaming or removal).