Fixes getColorClassName regression #32722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s it did with lodash kebabCase
glendaviesnz
added
[Type] Bug
|
Size Change: +711 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Prior to applying this PR and #32720 I could replicate the reported errors using the supplied block code. After applying these PRs the block was deemed valid.
There is just one small issue, the new regex doesn't allow hyphenated named color slugs e.g. subtle-background. I'm not certain if there are any restrictions on these color slugs other than being passed through a safe attributes filter. Given they can be defined by theme developers through the theme.json, is the rigid regex here satisfactory?
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
I'll add a bit of unit test coverage. |
ockham
reviewed
Jun 16, 2021
Comment on lines
+66
to
+70
| if ( 'string' !== typeof colorSlug ) { | ||
| colorSlug = String( colorSlug ); | ||
| // eslint-disable-next-line no-console | ||
| console.warn( 'The color slug should be a string.' ); | ||
| } |
There was a problem hiding this comment.
What non-string value would be permissible here? Numbers, for example, don't seem to make sense here, do they?
There was a problem hiding this comment.
Same comment as #32720 (comment) I think the issue is the same in both cases: that consumers of the API expected much more than we thought we offered. That there isn't a specific report yet doesn't mean there can't be some.
|
|
Updated the testing instructions to clarify how to have a subscription block available (still doing testing). |
|
We're reverting #32742 that caused the original issue. See also #32720 (comment) |
|
@nosolosw - did you want to keep this one open to circle back on this work, or will you open new PRs for the rework of this? Feel free to close it if not needed now. |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The removal of lodash kebabCase from getColorClassName meant that special characters where not being stripped from the resulting classnames, so blocks that were passing in
#ffffffas the color slug were expecting to seehas-ffffff-border-coloras the classname, but method is now returninghas-#ffffff-border-colorFixes: #32721
Step-by-step reproduction instructions
npm install && npm run build:plugin-zipand upload.Block should display as valid.