Card: add types #32561
Merged
Card: add types #32561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Package] Components
ciampo
requested review from
youknowriad,
gziolo,
diegohaz,
tyxla and
sarayourfriend
11 tasks
|
Size Change: 0 B Total Size: 1.03 MB ℹ️ View Unchanged
|
11 tasks
ciampo
force-pushed
the
feat/components-card-refactor-folder-structure
branch
from
a8f786a to
564c683
Compare
Base automatically changed from
feat/components-card-refactor-folder-structure
to
trunk
June 10, 2021 13:43
ciampo
force-pushed
the
feat/components-card-types
branch
from
77445ff to
dc6ad74
Compare
ciampo
force-pushed
the
feat/components-card-types
branch
from
dc6ad74 to
6bce1b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of a series of PRs with the final goal of achieving the same result as #32243 in smaller (and easier to review) steps.
Requires #32557 to be merged first.
This PR adds types to
<Card />and its subcomponents. The types may not be written in the most elegant way, but their main purpose is to simplify the review work on the upcoming PRs, which will focus on swapping the current implementation with the new one (g2).When refactoring to the new implementation, all components props will be types using the
PolymorphicComponentPropstype.Testing instructions
The changes are not affecting any runtime code.
Components / Cardstories against the production version — there shouldn't be any differenceScreenshots
N/A
Types of changes
Refactor (folder structure)
Checklist:
*.native.jsfiles for terms that need renaming or removal).