-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rnmobile/fix/disable controls when template lock is set #32495
Merged
enejb
merged 5 commits into
trunk
from
rnmobile/fix/disable-controls-when-templateLock-is-set
Jun 21, 2021
Merged
Rnmobile/fix/disable controls when template lock is set #32495
enejb
merged 5 commits into
trunk
from
rnmobile/fix/disable-controls-when-templateLock-is-set
Jun 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
chipsnyder
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM tested with wordpress-mobile/gutenberg-mobile#3513 (review)
… gutenberg bridge
This fixes a but in the block inserter button and make the feature match the web functionality.
8529138
to
2cf971b
Compare
2 tasks
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the #31777 and fixes:
Description
This Pr helps us test the new layout grid block on the mobile editor.
It fixes the issues found in the layout grid block while testing wordpress-mobile/gutenberg-mobile#3513.
It fixes them by showing the disabled the add new block action went the block is set to insert any new blocks.
This happens when the parent defines a
templateLock="all"
. Which makes the mobile implementation match what we have on the web. Fixing wordpress-mobile/gutenberg-mobile#3583See
![Screen Shot 2021-06-07 at 12 05 13 PM](https://user-images.githubusercontent.com/115071/121074377-9e490f80-c788-11eb-9dd0-d57874b2b9ae.png)
It also make the block action marked as disabled if the block does not present any block actions on the block.
Fixing wordpress-mobile/gutenberg-mobile#3582
See
![Screen Shot 2021-06-07 at 12 05 59 PM](https://user-images.githubusercontent.com/115071/121074453-b9b41a80-c788-11eb-9014-88e837a369a1.png)
How has this been tested?
Build the iOS app using
wordpress-mobile/WordPress-iOS#16543
Screenshots
See
Screen.Recording.2021-06-07.at.12.19.44.PM.mp4
Types of changes
Bug fixes.
Checklist:
*.native.js
files for terms that need renaming or removal).