Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard multiselect: support horizontal arrows #3245

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

mcsf
Copy link
Contributor

@mcsf mcsf commented Oct 30, 2017

Description

Implements #3244

How Has This Been Tested?

Screenshots (jpeg or gifs if applicable):

gut

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@mcsf mcsf added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Oct 30, 2017
@mcsf mcsf requested review from ephox-mogran and ellatrix October 30, 2017 16:20
@codecov
Copy link

codecov bot commented Oct 30, 2017

Codecov Report

Merging #3245 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3245      +/-   ##
==========================================
- Coverage   31.28%   31.25%   -0.04%     
==========================================
  Files         227      227              
  Lines        6411     6418       +7     
  Branches     1139     1143       +4     
==========================================
  Hits         2006     2006              
- Misses       3699     3702       +3     
- Partials      706      710       +4
Impacted Files Coverage Δ
editor/writing-flow/index.js 0% <0%> (ø) ⬆️
editor/block-mover/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8029705...16e2cc6. Read the comment docs.

Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@mcsf
Copy link
Contributor Author

mcsf commented Oct 30, 2017

😄

@mcsf mcsf merged commit a087b80 into master Oct 30, 2017
@mcsf mcsf deleted the add/horizontal-shift-multiselect branch October 30, 2017 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants