components: Add types to Icon #32219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
requested review from
jsnajdr,
sirreal,
ciampo,
diegohaz and
tyxla
|
Size Change: -10 B (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
tyxla
reviewed
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds types to the
Iconcomponent.It's a little messy, but I think it gets the job done at least (even though we have some ugly type casts). Curious what other folks think... if there's a better way to approach this. It's certainly not ideal.
Only one runtime change but I think it captures the intention of the function better.
The prop types are mostly copied from the DT definition for this component.
How has this been tested?
Type checks pass.
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).