Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Emotion 11 #32216

Closed
wants to merge 9 commits into from
Closed

Upgrade to Emotion 11 #32216

wants to merge 9 commits into from

Conversation

sarayourfriend
Copy link
Contributor

@sarayourfriend sarayourfriend commented May 25, 2021

Description

Upgrades to Emotion 11, includes a workaround for Storybook: storybookjs/storybook#13300 (comment)

This is based off of #31476 but opened in a fork so that those without Gutenberg repo access are able to contribute. Please see the previous PR for discussions.

How has this been tested?

Run Gutenberg with this PR and verify that Emotion components are still working as expected. Check that the StyleProvider is working as expected for iframes in FSE.

Also run storybook npm run storybook:dev and ensure that all Emotion components are working as expected.

Types of changes

Dependency upgrade. Non-breaking change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • [N/A] My code follows the accessibility standards.
  • [N/A] I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants