Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State: Reset editor undo history only at initial setup #3178

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented Oct 26, 2017

Fixes #2916
Fixes #2915

This pull request seeks to revise the action types on which the editor undo history is reset. The current RESET_POST reset type is insufficient for two reasons:

By changing the reset type to SETUP_EDITOR, we resolve both of these issues by only resetting at the final setup action during editor initialization.

Testing instructions:

Repeat testing instructions from #2916 and #2915, verifying that you can:

  • Undo after a save occurs
  • No undo when starting a new post

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Oct 26, 2017
@mtias mtias added this to the Beta 1.6 milestone Oct 31, 2017
@aduth aduth merged commit 77b146d into master Oct 31, 2017
@aduth aduth deleted the fix/2916-undo-new-post branch October 31, 2017 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undo level present on load Auto save wipes undo levels
3 participants