Use rich text hook for post title #31569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -211 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/post-title-rich-text
branch
2 times, most recently
from
b993e21 to
065032c
Compare
ellatrix
force-pushed
the
try/post-title-rich-text
branch
from
20092a3 to
b6ffc61
Compare
ellatrix
changed the title
ellatrix
force-pushed
the
try/post-title-rich-text
branch
from
d3f6edf to
2bc4056
Compare
ellatrix
commented
Aug 19, 2021
| @@ -21,9 +21,6 @@ describe( 'TypeWriter', () => { | |||
| // Create first block. | |||
| await page.keyboard.press( 'Enter' ); | |||
|
|
|||
| // Create second block. | |||
| await page.keyboard.press( 'Enter' ); | |||
There was a problem hiding this comment.
The post title has become bigger, so we have to test with less blocks.
ellatrix
commented
Aug 19, 2021
| @@ -314,10 +317,8 @@ describe( 'Template Part', () => { | |||
| ); | |||
| await chooseExistingButton.click(); | |||
| const preview = await page.waitForSelector( | |||
| '.block-editor-block-preview__content iframe' | |||
| '[aria-label="Create New"]' | |||
There was a problem hiding this comment.
I saw that this test is unstable. This should stabilise it.
7 tasks
annezazu
added
[Block] Post Title
7 tasks
jeremyfelt
added a commit
to jeremyfelt/shortnotes
that referenced
this pull request
Nov 26, 2021
This was originally used to provide a friendlier note when a note was published rather than (no title) is live. A change in Gutenberg 11.4.0 caused this to not work anymore and instead crash the editor when the note was saved. See WordPress/gutenberg@647547a from WordPress/gutenberg#31569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6897.
Makes the post title a real preview of the from end by using the right tag (h1).
Note that the post title will now have a different size depending on the theme. For 2021, this is a bit larger than it used to be, but this is normal, it's the same size as the front-end.
Ideally we should use the post title block here, but this is a good substitute for now.
Also removes excessive rerenders of the auto resizing text area component.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).