components: Promote Divider and use readable prop names #31556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
|
Size Change: -150 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
May 7, 2021
|
Unit tests are failing and there is one error reported by ESLint. Once it's resolved it's good to go. |
7 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Promotes
Dividerand renames its props to readable names.How has this been tested?
Divider is unused so just unit tests and storybook.
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).