[RNMobile] Add Featured Banner to Image Block (iOS Only) #31347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 29, 2021 17:27
…ImageId() over the bridge gutenbergFeaturedImageId() will be used to gather the initial ID of a post's featured image when the editor first loads in iOS.
…featured image over the bridge
7 tasks
SiobhyB
added
the
Mobile App - i.e. Android or iOS
Merged
2 tasks
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
"border-radius" doesn't function as intended on iOS devices without use of "overflow: hidden".
7 tasks
…er.swift This is to align the code in the demo file with the code in GutenbergBridgeDataSource, so that it runs as expected.
SiobhyB
force-pushed
the
add/featured-badge-ios
branch
from
90b2904 to
f32618a
Compare
…/featured-badge-ios
4 tasks
This was referenced May 3, 2021
…/featured-badge-ios
SiobhyB
requested review from
adamziel,
cameronvoell,
draganescu,
ellatrix,
guarani,
kevin940726,
mkaz,
mkevins,
nerrad and
noisysocks
as code owners
SiobhyB
requested review from
oandregal,
ntwb,
spacedmonkey,
talldan,
tellthemachines and
TimothyBJacobs
as code owners
SiobhyB
force-pushed
the
add/featured-badge-ios
branch
from
bef850d to
b43d6f6
Compare
…/featured-badge-ios
|
@illusaen, thank you again for the review! Following our Slack conversation, I just want to double-check here whether you had anything else in mind before merging. If not, I've now set myself as the assignee on all three PRs and will start the merge domino once you give the thumbs up. :) |
SiobhyB
added a commit
that referenced
this pull request
Aug 2, 2021
…ctly from Image Block (iOS Only) (#31345) * Update CHANGELOG.md with feature details * [RNMobile] Add Featured Banner to Image Block (iOS Only) (#31347) Add a "featured" banner that overlays the image block on iOS devices. * [RNMobile] Add "Set as Featured Image" Button to Image Block (iOS Only) (#31415) Add "Set as Featured Image" Button to Image Block * Update CHANGELOG.md
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paritial fix for: wordpress-mobile/gutenberg-mobile#1011
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#3390WordPress-iOS: wordpress-mobile/WordPress-iOS#16332The main PR for the branch this individual PR will be merged into,
add/featured-functionality-to-image-block-ios, can be found here: #31345Description
This PR introduces a Featured banner, which overlays a post's featured image when it's added to an image block. This will make it easier for users to identify which of the images in their posts, if any, are set as featured directly from the editor.
Note: This PR introduces the Featured banner on iOS devices only, building on the work done in #30806 to add the banner to Android devices.
How has this been tested?
Test Case 1: General Flow
To start with, an image block should be updated to reflect whether its image is featured or not when set via the general Post Settings flow:
Test Case 2: "Editor Loads" Flow
Next, we should verify that a Featured banner appears when a post with a featured image is first loaded. To test this, follow these steps:
Test Case 3: "Replace in Image Block" Flow
Finally, it's possible to replace an image directly within the image block's settings. We need to verify that the Featured banner updates as expected depending on the image that's chosen for an image block:
Screenshots
Types of changes
This PR introduces a new feature (non-breaking change which adds functionality).
In #30806, changes were introduced to display a
Featuredbanner on Android devices. That PR can be referred to for further details on the badge component that's used for the banner and the logic for storingfeaturedImageIdin the image component's edit.native.js file. To build on those changes and display the banner on iOS devices, the following main changes were introduced to the code:gutenbergFeaturedImageIdis passed over the bridge to gather any initial featured image ID when a post is first loads.Checklist:
*.native.jsfiles for terms that need renaming or removal).