components: Promote ui/Flex and deprecate isReversed prop
#31297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: -382 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Apr 29, 2021
gziolo
reviewed
Apr 29, 2021
| ``` | ||
|
|
||
| The most common use-case for `<Flex />` would be to automatically align two (or more) child items of varying sizes. By default, `<Flex />` would vertically center align them, and evenly spread the inner content horizontally, starting at the edges. |
There was a problem hiding this comment.
Should we keep some parts of the old documentation?
gziolo
reviewed
Apr 29, 2021
|
|
||
| ## Sub-Components |
There was a problem hiding this comment.
Do we get sub-components undocumented with the changes proposed?
In practice, when every component exposed in the public API is in its own folder, we can create a README.md file that gets automatically exposed to the developer portal:
https://developer.wordpress.org/block-editor/reference-guides/components/
Every README file gets a link in the sidebar menu.
There was a problem hiding this comment.
Sure! I can move them into their own folders 🙂
gziolo
reviewed
Apr 29, 2021
gziolo
reviewed
Apr 29, 2021
gziolo
reviewed
Apr 29, 2021
Co-authored-by: Greg Ziółkowski <[email protected]>
Co-authored-by: Greg Ziółkowski <[email protected]>
sarayourfriend
force-pushed
the
add/promote-flex
branch
from
ec64274 to
0edc7d0
Compare
gziolo
approved these changes
Apr 30, 2021
gziolo
reviewed
Apr 30, 2021
gziolo
reviewed
Apr 30, 2021
|
As far as I can tell, the example in Storybook needs some adjustments:
|
7 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Promotes
ui/Flexinto the canonicalFlexcomponent for WordPress/components. Also deprecates theisReversedprop.This conflicts with #30261 but replaces the need for it as the new component supports the direction prop.
How has this been tested?
Run Gutenberg and make sure things still work, especially block dragging and other things that use Flex (angle picker control for example).
Types of changes
Non-breaking changes.
Checklist:
*.native.jsfiles for terms that need renaming or removal).