components: Promote Text to full components export #31291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Breaking Change
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: -388 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
add/upgrade-text
branch
2 times, most recently
from
47990c0 to
820abc3
Compare
sarayourfriend
force-pushed
the
add/upgrade-text
branch
from
820abc3 to
195be4a
Compare
gziolo
force-pushed
the
add/upgrade-text
branch
from
195be4a to
d1f1fe1
Compare
gziolo
force-pushed
the
add/upgrade-text
branch
from
d1f1fe1 to
3d9ae4e
Compare
|
All those snapshot tests must be really slow. The tests for components alone take 40 seconds to run:
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces
Textwithui/Text.This keeps the existing implementation for React native. I didn't actually see it being used in React native (React native has its own
Textcomponent) so I'm not sure we even need a React native implementation of this? Who would be best to ask?How has this been tested?
Run Gutenberg and test some controls as well as the spacer tooltip to ensure that they work as expected.
Types of changes
New feature.
Breaking change, but it's behind
__experimentalso I think it should be okay to make this breaking change.Checklist:
*.native.jsfiles for terms that need renaming or removal).