components: Remove G2 portal and refactor Popover to no longer use G2 #31209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +96 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
remove/wp-g2-portal
branch
from
031e025 to
b3dfda5
Compare
This was referenced Apr 26, 2021
youknowriad
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the G2 portal in favor of just using Reakit's portal directly. The G2 portal is no longer necessary as we don't have a theme provider anymore. We also have to refactor wp-g2 out of Popover as a consequence of this so this PR goes ahead and does that too.
Part of #30503
How has this been tested?
Popover continues to work in storybook.
Types of changes
Code removal.
Checklist:
*.native.jsfiles for terms that need renaming or removal).